Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 Remove and prevent unused eslint directives #32538

Merged
merged 1 commit into from
Feb 9, 2021
Merged

🏗 Remove and prevent unused eslint directives #32538

merged 1 commit into from
Feb 9, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Feb 9, 2021 •
edited
Loading

This PR enables the detection of eslint directives that have become unnecessary, and cleans up the one such instance in our code.

Reference: https://eslint.org/docs/developer-guide/nodejs-api#cliengine

Addresses https://github.com/ampproject/amphtml/pull/32397/files#r572619849

@rsimha rsimha requested a review from dvoytenko February 9, 2021 06:27
@rsimha rsimha self-assigned this Feb 9, 2021
@rsimha rsimha mentioned this pull request Feb 9, 2021
Merged
@rsimha rsimha merged commit 327d021 into ampproject:master Feb 9, 2021
@rsimha rsimha deleted the 2021-02-09-Eslint branch February 9, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvoytenko dvoytenko dvoytenko approved these changes

Assignees

@rsimha rsimha

Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsimha @dvoytenko @ampprojectbot